Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce sd timeout #9178

Closed
wants to merge 1 commit into from
Closed

Reduce sd timeout #9178

wants to merge 1 commit into from

Conversation

bill88t
Copy link

@bill88t bill88t commented Apr 14, 2024

Closes #9175.

Tested on WIO Terminal.

@bill88t bill88t marked this pull request as ready for review April 15, 2024 12:50
@hyx0329
Copy link

hyx0329 commented Apr 15, 2024

Hi, this patch doesn't solve the issue that under certain circumstances(or corner case) all call to cmd are timed out, leading to a maximum delay of 200 * 3 * 300 ms = 180,000 ms = 180 seconds.

The last parameter of cmd is a flag to indicate if it should wait using wait_for_ready, whose timeout is defined by READY_TIMEOUT_NS(300ms in the comment).

@bill88t
Copy link
Author

bill88t commented May 2, 2024

I could not come up with a better patch. Closing PR.

@bill88t bill88t closed this May 2, 2024
@bill88t bill88t deleted the sdtimeout branch May 2, 2024 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sdcardio internal init_card_v2 maximum potential timeout is ridiculously long
2 participants