Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

slim down thunderpack v12 more #8650

Closed
wants to merge 1 commit into from
Closed

Conversation

imnotjames
Copy link

@imnotjames imnotjames commented Nov 22, 2023

drops ulab from the thunderpack v12 to drastically reduce the flash usage

drops ulab from the thunderpack v12 to drastically reduce the byte usage of flash
@imnotjames
Copy link
Author

imnotjames commented Nov 22, 2023

This is to fix the failure in #8647 per @dhalbert 's feedback

@imnotjames imnotjames marked this pull request as ready for review November 22, 2023 17:50
dhalbert
dhalbert previously approved these changes Nov 22, 2023
@dhalbert dhalbert dismissed their stale review November 22, 2023 18:49

add to 8647 instead

@dhalbert
Copy link
Collaborator

Add this change to #8647 instead, so we don't have to do two full builds.

@imnotjames
Copy link
Author

Add this change to #8647 instead, so we don't have to do two full builds.

Sure - wasn't sure the approach that should be done for this & how it would affect rollbacks.

@dhalbert
Copy link
Collaborator

Sure - wasn't sure the approach that should be done for this & how it would affect rollbacks.

This is minor enough that it's fine. We have often had to slim down multiple builds in the past when new features are added.

@dhalbert dhalbert closed this Nov 22, 2023
@imnotjames
Copy link
Author

Done - closing in favor of including this fully within #8647

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants