Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change readFullPacket #187

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Change readFullPacket #187

wants to merge 1 commit into from

Conversation

mpoettgen
Copy link

  • rename 'value' to 'remainingLength' to provide better semantics.
  • introduce 'fixedHeaderLength' for better semantics.
  • refactor if expression to avoid compiler warning

fixes #182

@mpoettgen
Change readFullPacket
44d7cc4 
* rename 'value' to 'remainingLength' to provide better semantics.
* introduce 'fixedHeaderLength' for better semantics.
* refactor if expression to avoid compiler warning
flavio-fernandes
flavio-fernandes approved these changes Feb 15, 2021
View reviewed changes
Copy link
Contributor

@flavio-fernandes flavio-fernandes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT, short of a few nits.

Adafruit_MQTT.cpp Show resolved Hide resolved
Adafruit_MQTT.cpp Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brentru brentru brentru left review comments

@flavio-fernandes flavio-fernandes flavio-fernandes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Adafruit_MQTT.cpp:264:46: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
3 participants
@mpoettgen @brentru @flavio-fernandes