Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom Reports: TS strict changes #1 #2726

Merged
merged 5 commits into from May 13, 2024
Merged

Conversation

carkom
Copy link
Contributor

@carkom carkom commented May 8, 2024

Making files in custom reports to comply with TS strict - stage 1.

@trafico-bot trafico-bot bot added the 🔍 Ready for Review Pull Request is not reviewed yet label May 8, 2024
Copy link

netlify bot commented May 8, 2024

Deploy Preview for actualbudget ready!

Name Link
🔨 Latest commit 4a1c12c
🔍 Latest deploy log https://app.netlify.com/sites/actualbudget/deploys/66419a239726220008dffcbd
😎 Deploy Preview https://deploy-preview-2726.demo.actualbudget.org
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot changed the title Custom Reports: TS strict changes [WIP] Custom Reports: TS strict changes May 8, 2024
@trafico-bot trafico-bot bot added 🚧 WIP Still work-in-progress, please don't review and don't merge and removed 🔍 Ready for Review Pull Request is not reviewed yet labels May 8, 2024
Copy link
Contributor

github-actions bot commented May 8, 2024

Bundle Stats — desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
9 4.71 MB → 4.71 MB (+1.03 kB) +0.02%
Changeset
File Δ Size
src/components/reports/graphs/tableGraph/RenderTableRow.tsx 🆕 +519 B 0 B → 519 B
src/components/reports/graphs/adjustTextSize.ts 📈 +196 B (+7.68%) 2.49 kB → 2.68 kB
src/components/reports/spreadsheets/calculateLegend.ts 📈 +37 B (+5.29%) 699 B → 736 B
src/components/reports/graphs/tableGraph/ReportTableList.tsx 📈 +103 B (+4.74%) 2.12 kB → 2.22 kB
src/components/reports/ReportSummary.tsx 📈 +32 B (+0.83%) 3.78 kB → 3.82 kB
src/components/reports/graphs/tableGraph/ReportTableTotals.tsx 📈 +48 B (+0.72%) 6.47 kB → 6.52 kB
src/components/reports/graphs/tableGraph/ReportTableHeader.tsx 📈 +17 B (+0.66%) 2.5 kB → 2.52 kB
src/components/reports/graphs/BarGraph.tsx 📈 +39 B (+0.42%) 9.13 kB → 9.16 kB
src/components/reports/spreadsheets/custom-spreadsheet.ts 📈 +15 B (+0.35%) 4.16 kB → 4.18 kB
src/components/reports/graphs/AreaGraph.tsx 📈 +27 B (+0.33%) 8.01 kB → 8.04 kB
src/components/reports/graphs/DonutGraph.tsx 📈 +27 B (+0.32%) 8.27 kB → 8.29 kB
src/components/reports/ChooseGraph.tsx 📉 -3 B (-0.07%) 3.91 kB → 3.91 kB
src/components/reports/graphs/tableGraph/ReportTable.tsx 📉 -2 B (-0.11%) 1.85 kB → 1.85 kB
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

Asset File Size % Changed
static/js/ReportRouter.js 1.23 MB → 1.23 MB (+1.03 kB) +0.08%

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
static/js/indexeddb-main-thread-worker-e59fee74.js 13.5 kB 0%
static/js/resize-observer.js 18.37 kB 0%
static/js/BackgroundImage.js 122.29 kB 0%
static/js/usePreviewTransactions.js 790 B 0%
static/js/AppliedFilters.js 20.53 kB 0%
static/js/narrow.js 59.81 kB 0%
static/js/wide.js 262.4 kB 0%
static/js/index.js 3 MB 0%

Copy link
Contributor

github-actions bot commented May 8, 2024

Bundle Stats — loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
1 1.2 MB 0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
kcab.worker.js 1.2 MB 0%

@carkom carkom changed the title [WIP] Custom Reports: TS strict changes Custom Reports: TS strict changes #1 May 8, 2024
@trafico-bot trafico-bot bot added 🔍 Ready for Review Pull Request is not reviewed yet and removed 🚧 WIP Still work-in-progress, please don't review and don't merge labels May 8, 2024
@carkom carkom requested review from MatissJanis and twk3 May 11, 2024 06:49
@carkom carkom requested a review from twk3 May 13, 2024 05:15
Copy link
Contributor

@twk3 twk3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@trafico-bot trafico-bot bot added ✅ Approved Pull Request has been approved and can be merged and removed 🔍 Ready for Review Pull Request is not reviewed yet labels May 13, 2024
@carkom carkom merged commit 9c3075f into actualbudget:master May 13, 2024
19 checks passed
@trafico-bot trafico-bot bot added ✨ Merged Pull Request has been merged successfully and removed ✅ Approved Pull Request has been approved and can be merged labels May 13, 2024
@carkom carkom deleted the CR-strict1 branch May 16, 2024 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ Merged Pull Request has been merged successfully
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants