New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 fix networth graph loading forever for empty budgets #2725
Conversation
✅ Deploy Preview for actualbudget ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@@ -41,6 +42,7 @@ | |||
"inter-ui": "^3.19.3", | |||
"jest": "^27.5.1", | |||
"jest-watch-typeahead": "^2.2.2", | |||
"lodash": "^4.17.21", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding lodash. I think using these utils instead of rebuilding our own (and making them strict TS compliant) would be a good thing. It would definitely save us time. LMK if you disagree.
if (accounts.length === 0) { | ||
return null; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the only functional change. Everything else is to make this file TS strict compliant.
@@ -18,18 +18,6 @@ export async function runAll( | |||
cb(data); | |||
} | |||
|
|||
export function index< |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Making this strict TS compliant was a big pain.. so instead I opted to use lodash
.
Bundle Stats — desktop-clientHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger
Smaller No assets were smaller Unchanged
|
Bundle Stats — loot-coreHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset No files were changed View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
* 🐛 fix networth graph loading forever for empty budgets (actualbudget#2725) * add release workflow --------- Co-authored-by: Matiss Janis Aboltins <matiss@mja.lv>
Fix #2711
Do not show the loading indicator forever in empty budget files.