Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] reports: Fix scrollbar colors. #2675

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

glowtape
Copy link

Who knows why it doesn't show otherwise. Probably plenty of messing about with -webkit-scrollbar way up the component tree.

image

image

@github-actions github-actions bot changed the title reports: Fix scrollbar colors. [WIP] reports: Fix scrollbar colors. Apr 27, 2024
@trafico-bot trafico-bot bot added the 🔍 Ready for Review Pull Request is not reviewed yet label Apr 27, 2024
Copy link

netlify bot commented Apr 27, 2024

Deploy Preview for actualbudget ready!

Name Link
🔨 Latest commit 69d6360
🔍 Latest deploy log https://app.netlify.com/sites/actualbudget/deploys/662d3cfb68968e0008d9a08d
😎 Deploy Preview https://deploy-preview-2675.demo.actualbudget.org
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@trafico-bot trafico-bot bot added 🚧 WIP Still work-in-progress, please don't review and don't merge and removed 🔍 Ready for Review Pull Request is not reviewed yet labels Apr 27, 2024
Copy link
Contributor

github-actions bot commented Apr 27, 2024

Bundle Stats — desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
9 4.68 MB → 4.68 MB (+157 B) +0.00%
Changeset
File Δ Size
src/components/reports/graphs/tableGraph/ReportTableTotals.tsx 📈 +79 B (+2.07%) 3.73 kB → 3.81 kB
src/components/reports/CategorySelector.tsx 📈 +78 B (+0.91%) 8.37 kB → 8.44 kB
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

Asset File Size % Changed
static/js/ReportRouter.js 1.2 MB → 1.2 MB (+157 B) +0.01%

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
static/js/indexeddb-main-thread-worker-e59fee74.js 13.5 kB 0%
static/js/resize-observer.js 18.37 kB 0%
static/js/usePreviewTransactions.js 790 B 0%
static/js/AppliedFilters.js 20.41 kB 0%
static/js/BackgroundImage.js 122.29 kB 0%
static/js/narrow.js 59.68 kB 0%
static/js/wide.js 263.53 kB 0%
static/js/index.js 2.99 MB 0%

Copy link
Contributor

github-actions bot commented Apr 27, 2024

Bundle Stats — loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
1 1.2 MB 0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
kcab.worker.js 1.2 MB 0%

@@ -132,6 +133,7 @@ export function CategorySelector({
paddingRight: 10,
flexGrow: 1,
overflowY: 'auto',
scrollbarColor: theme.tableBackground + ' ' + theme.pageBackground,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The app uses a set of scrollbar styles e.g. styles.lightScrollbar or styles.darkScrollbar. We can try applying either of those styles here to be consistent with other parts of the app.

@joel-jeremy joel-jeremy added the ⚠️ Changes requested Pull Request needs changes before it can be reviewed again label May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⚠️ Changes requested Pull Request needs changes before it can be reviewed again 🚧 WIP Still work-in-progress, please don't review and don't merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants