[Feature] Make comma's and period interchangeable when entering figures #2672
Conversation
github-actions
bot
changed the title
✅ Deploy Preview for actualbudget ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
trafico-bot
bot
added
🚧 WIP
Bundle Stats — desktop-clientHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger
Smaller No assets were smaller Unchanged
|
Bundle Stats — loot-coreHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger
Smaller No assets were smaller Unchanged No assets were unchanged |
Wizmaster
force-pushed
the
feature/merge-comma-dot
branch
from
f853ba0
to
8a67670
Compare
Wizmaster
changed the title
trafico-bot
bot
added
🔍 Ready for Review
Wizmaster
force-pushed
the
feature/merge-comma-dot
branch
from
8a67670
to
b0caae0
Compare
|
@Wizmaster Can you provide some steps to test these changes out? |
|
@joel-jeremy You can use the test budget with the number formatting "1 000,33" (or "1 000.33"). The PR allow then to input amounts with "10.50" or "10,50" in transactions or budget values. It also allow to use arithmetic like "$10.50+$10.25" or "26€-5,25€" with the correct result (20.75 both). |
trafico-bot
bot
added
the
✅ Approved
| @@ -237,13 +237,14 @@ export function getNumberFormat({ | |||
| format?: NumberFormats; | |||
| hideFraction: boolean; | |||
| } = numberFormatConfig) { | |||
| let locale, regex, separator; | |||
| let locale, regex, separator, regexSeparator; | |||
There was a problem hiding this comment.
Nit:
| let locale, regex, separator, regexSeparator; | |
| let locale, regex, separator, separatorRegex; |
There was a problem hiding this comment.
@joel-jeremy Done, I renamed the variable.
- Only allowed for formats not using period or comma as a thousand separator
Wizmaster
force-pushed
the
feature/merge-comma-dot
branch
from
b0caae0
to
b90402c
Compare
trafico-bot
bot
removed
the
✅ Approved
trafico-bot
bot
added
✅ Approved
trafico-bot
bot
added
✨ Merged
Implements #2318
It's only allowed for formats not using period or comma as a thousand separator. I don't think somebody using a format with comma and dot as decimal and thousand separator would have the issue in the first place.
I reworked the arithmetic parser to let
currencyToAmount()handle number formatting with active format. I noticed it also made an exception for a leading currency symbol but not for a tailing one. I fixed it to allow that case. (actually in my implementation you could also put a currency symbol in the middle of a value but it would be ignored anyway, I don't think it's an issue)