Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] [Maintenance] trivial JSX components conversion to TSX #2666

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jycrhl
Copy link

@jycrhl jycrhl commented Apr 26, 2024

Part of #1483

@trafico-bot trafico-bot bot added the 🔍 Ready for Review Pull Request is not reviewed yet label Apr 26, 2024
Copy link

netlify bot commented Apr 26, 2024

Deploy Preview for actualbudget ready!

Name Link
🔨 Latest commit 540f85b
🔍 Latest deploy log https://app.netlify.com/sites/actualbudget/deploys/662b01cede480e00080bf212
😎 Deploy Preview https://deploy-preview-2666.demo.actualbudget.org
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jycrhl jycrhl changed the title [Maintenance] convert trivial JSX components to TSX [Maintenance] trivial JSX components conversion to TSX Apr 26, 2024
@jycrhl jycrhl marked this pull request as ready for review April 26, 2024 01:33
Copy link
Contributor

Bundle Stats — desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
9 4.68 MB 0%
Changeset
File Δ Size
src/components/manager/ManagementApp.tsx 🆕 +6.91 kB 0 B → 6.91 kB
src/components/mobile/transactions/Option.tsx 🆕 +764 B 0 B → 764 B
src/components/reports/Change.tsx 🆕 +291 B 0 B → 291 B
src/components/manager/ManagementApp.jsx 🔥 -6.91 kB (-100%) 6.91 kB → 0 B
src/components/mobile/transactions/Option.jsx 🔥 -764 B (-100%) 764 B → 0 B
src/components/reports/Change.jsx 🔥 -291 B (-100%) 291 B → 0 B
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
static/js/indexeddb-main-thread-worker-e59fee74.js 13.5 kB 0%
static/js/resize-observer.js 18.37 kB 0%
static/js/BackgroundImage.js 122.29 kB 0%
static/js/narrow.js 59.72 kB 0%
static/js/AppliedFilters.js 20.35 kB 0%
static/js/usePreviewTransactions.js 790 B 0%
static/js/wide.js 263.53 kB 0%
static/js/ReportRouter.js 1.2 MB 0%
static/js/index.js 2.99 MB 0%

Copy link
Contributor

Bundle Stats — loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
1 1.2 MB → 1.2 MB (-40 B) -0.00%
Changeset
File Δ Size
packages/loot-core/src/server/accounts/parse-file.ts 📉 -60 B (-1.67%) 3.52 kB → 3.46 kB
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

Asset File Size % Changed
kcab.worker.js 1.2 MB → 1.2 MB (-40 B) -0.00%

Unchanged

No assets were unchanged

@MatissJanis
Copy link
Member

👋 Thanks for starting to work on this! Could you please take a look at the failing CI jobs (except the "merge freeze" one - you can ignore that one) and see to get them all green? Thanks again!

@MatissJanis MatissJanis changed the title [Maintenance] trivial JSX components conversion to TSX [WIP] [Maintenance] trivial JSX components conversion to TSX Apr 27, 2024
@trafico-bot trafico-bot bot added 🚧 WIP Still work-in-progress, please don't review and don't merge and removed 🔍 Ready for Review Pull Request is not reviewed yet labels Apr 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚧 WIP Still work-in-progress, please don't review and don't merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants