New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't update transaction date when importing manually #2648
Don't update transaction date when importing manually #2648
Conversation
✅ Deploy Preview for actualbudget ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Bundle Stats — desktop-clientHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset No files were changed View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
Bundle Stats — loot-coreHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller
Unchanged No assets were unchanged |
5ac592f
to
7eeca9d
Compare
- Manual import should not override the transaction date as done with bank account sync
7eeca9d
to
af5d001
Compare
@Wizmaster what do you think about making this conditional on the cleared status? That way uncleared items still get updated with the import, but you can manually edit dates for imported records and they won't be overwritten on further imports? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've been trying to think of any scenario where this change might not be favourable, but can't come up with anything. So IMO this is good to go.
But still I'd prefer another maintainer to review this. Just as a double-check.
@twk3 I think that if a transaction exists before import (manual or bank sync), the inputted date should be kept. I know that sometimes banks can use a later date due to batched transactions not always sent in time, it would be better to always keep the date the end-user inputted. |
I cant think of a reason to have bank sync act differently than a file import. In theory they should be the same, just one is automated. Ill merge this is for now and we will see if any edge users complain about the change. |
Following work done in #1559 and update in #2534 (discussion #2534 (comment)), I think manual import should not override the transaction date as is done with bank account sync.