Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't update transaction date when importing manually #2648

Merged

Conversation

Wizmaster
Copy link
Contributor

Following work done in #1559 and update in #2534 (discussion #2534 (comment)), I think manual import should not override the transaction date as is done with bank account sync.

@trafico-bot trafico-bot bot added the 🔍 Ready for Review Pull Request is not reviewed yet label Apr 20, 2024
@github-actions github-actions bot changed the title Don't update transaction date when importing manually [WIP] Don't update transaction date when importing manually Apr 20, 2024
Copy link

netlify bot commented Apr 20, 2024

Deploy Preview for actualbudget ready!

Name Link
🔨 Latest commit af5d001
🔍 Latest deploy log https://app.netlify.com/sites/actualbudget/deploys/6636960305296d000801bcfe
😎 Deploy Preview https://deploy-preview-2648.demo.actualbudget.org
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@trafico-bot trafico-bot bot added 🚧 WIP Still work-in-progress, please don't review and don't merge and removed 🔍 Ready for Review Pull Request is not reviewed yet labels Apr 20, 2024
Copy link
Contributor

github-actions bot commented Apr 20, 2024

Bundle Stats — desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
9 4.7 MB 0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
static/js/indexeddb-main-thread-worker-e59fee74.js 13.5 kB 0%
static/js/resize-observer.js 18.37 kB 0%
static/js/BackgroundImage.js 122.29 kB 0%
static/js/narrow.js 59.7 kB 0%
static/js/usePreviewTransactions.js 790 B 0%
static/js/AppliedFilters.js 20.41 kB 0%
static/js/wide.js 263.53 kB 0%
static/js/ReportRouter.js 1.22 MB 0%
static/js/index.js 2.99 MB 0%

Copy link
Contributor

github-actions bot commented Apr 20, 2024

Bundle Stats — loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
1 1.2 MB → 1.2 MB (-22 B) -0.00%
Changeset
File Δ Size
packages/loot-core/src/server/accounts/sync.ts 📉 -102 B (-0.45%) 22.13 kB → 22.04 kB
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

Asset File Size % Changed
kcab.worker.js 1.2 MB → 1.2 MB (-22 B) -0.00%

Unchanged

No assets were unchanged

@Wizmaster Wizmaster force-pushed the bugfix/no-date-update-on-import branch from 5ac592f to 7eeca9d Compare April 20, 2024 16:48
@Wizmaster Wizmaster changed the title [WIP] Don't update transaction date when importing manually Don't update transaction date when importing manually Apr 20, 2024
@trafico-bot trafico-bot bot added 🔍 Ready for Review Pull Request is not reviewed yet and removed 🚧 WIP Still work-in-progress, please don't review and don't merge labels Apr 20, 2024
- Manual import should not override the transaction date as done with bank account sync
@Wizmaster Wizmaster force-pushed the bugfix/no-date-update-on-import branch from 7eeca9d to af5d001 Compare May 4, 2024 20:09
@twk3
Copy link
Contributor

twk3 commented May 13, 2024

@Wizmaster what do you think about making this conditional on the cleared status?

That way uncleared items still get updated with the import, but you can manually edit dates for imported records and they won't be overwritten on further imports?

Copy link
Member

@MatissJanis MatissJanis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've been trying to think of any scenario where this change might not be favourable, but can't come up with anything. So IMO this is good to go.

But still I'd prefer another maintainer to review this. Just as a double-check.

@trafico-bot trafico-bot bot added ✅ Approved Pull Request has been approved and can be merged and removed 🔍 Ready for Review Pull Request is not reviewed yet labels May 14, 2024
@Wizmaster
Copy link
Contributor Author

@twk3 I think that if a transaction exists before import (manual or bank sync), the inputted date should be kept. I know that sometimes banks can use a later date due to batched transactions not always sent in time, it would be better to always keep the date the end-user inputted.

@MatissJanis 👍

@youngcw
Copy link
Contributor

youngcw commented May 15, 2024

I cant think of a reason to have bank sync act differently than a file import. In theory they should be the same, just one is automated. Ill merge this is for now and we will see if any edge users complain about the change.

@youngcw youngcw merged commit e5933ad into actualbudget:master May 15, 2024
19 checks passed
@trafico-bot trafico-bot bot added ✨ Merged Pull Request has been merged successfully and removed ✅ Approved Pull Request has been approved and can be merged labels May 15, 2024
@Wizmaster Wizmaster deleted the bugfix/no-date-update-on-import branch May 17, 2024 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ Merged Pull Request has been merged successfully
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants