New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Mobile] Budget table revamp #2642
base: master
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for actualbudget ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Bundle Stats — desktop-clientHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger
Smaller
Unchanged
|
Bundle Stats — loot-coreHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller
Unchanged No assets were unchanged |
dead25a
to
43a7a6f
Compare
e0d1ea1
to
f4e88d2
Compare
4ea0e0d
to
4ffe0e3
Compare
@jsehnoutka Thanks for the feedback! Pushed some changes to resize text when amount gets too long |
@joel-jeremy Looks great now, thanks for your work! Would it be possible to leave the same amount of characters available for the category name though? Maybe put the new > UI element a little bit to the right and assign fixed position to it? There are now less characters available for the category name before the line breaks, also the > UI element does not look very streamlined because it shows on different positions depending on the category name length. I think it would look better if it had consistent place on each line (category), nevertheless the text lenght. Before: After: |
Agree, category chevron would look best aligned with the group chevron. Not too sure about it changing alignment between groups, but when aligned with the group one you'll know the position will always work for the categories within the group as the group level totals the values underneath so will always have the widest numbers. |
Pushed an update
Yes it's tapable |
I not sure what I think about the lined up category arrows. Im fine with all the other changes though |
I'm also torn on lining up the cheverons on the group/category names. Lining them up looks good visually but also kinda wastes some space. I'm a leaning a bit towards not lining them up since that's how the desktop does it in the desktop budget table. More feedback would be good here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any idea why this would be changing?
48570c2
to
af81b52
Compare
And I guess this is just a bigger design question, as now there are chevrons all over and that apparently means "you can click on this". But it does somewhat confuse the viewer because chevrons mean "expand this" in some contexts. The old style with underlines was clear: underlined text are links, you can click on those. |
6bac9e1
to
b1ceab8
Compare
No description provided.