Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

actix-http: Add rustls 0.23 #3361

Merged
merged 11 commits into from May 18, 2024
Merged

Conversation

asonix
Copy link
Contributor

@asonix asonix commented May 12, 2024

PR Type

Feature

PR Checklist

  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • A changelog entry has been made for the appropriate packages.
  • Format code with the latest stable rustfmt.
  • (Team) Label with affected crates and semver status.

Overview

Adds support for rustls 0.23 to actix-http in the same way rustls 0.22 support was exposed

asonix added 4 commits May 3, 2024 14:03
When the feature for rustls 0.22 is enabled, and rustls 0.23 is also
present in a project, there suddently exist multiple paths for errors
when building middleware chains due to the use of two consecutive `?`
operators without specifying the intermediate error type.

This commit addresses the issue by removing the first `?`, so that the
first error type will always be known, and the second `?` always has a
well defined implementation.
@asonix
Copy link
Contributor Author

asonix commented May 12, 2024

includes changes from #3348

@asonix asonix mentioned this pull request May 12, 2024
5 tasks
@robjtede robjtede added A-http project: actix-http B-semver-minor labels May 14, 2024
@robjtede robjtede added this pull request to the merge queue May 18, 2024
@robjtede robjtede removed this pull request from the merge queue due to a manual request May 18, 2024
@robjtede robjtede merged commit 2d035c0 into actix:master May 18, 2024
13 checks passed
jonatansalemes pushed a commit to jonatansalemes/actix-web that referenced this pull request May 19, 2024
Co-authored-by: Rob Ede <robjtede@icloud.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-http project: actix-http B-semver-minor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants