Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filter out IPv6 reverse DNS lookups from DNS analysis #710

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Filter out IPv6 reverse DNS lookups from DNS analysis #710

wants to merge 2 commits into from

Conversation

nighttardis
Copy link

Fixes #709 and excludes ip6.arpa requests similar to how in-addr.arpa requests are excluded.

Zalgo2462
Zalgo2462 reviewed Oct 5, 2021
View reviewed changes
Copy link
Contributor

@Zalgo2462 Zalgo2462 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code LGTM. Thank you for submitting this patch!

The ACM team will need to come back and test this before pulling it in, but the code itself has my seal of approval.

@Zalgo2462 Zalgo2462 changed the title 709 ip6 arpa Filter out IPv6 reverse DNS lookups from DNS analysis Oct 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zalgo2462 Zalgo2462 Zalgo2462 left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

IP v6 arpa request are showing up in the "exploded dns" report
2 participants
@nighttardis @Zalgo2462