Photon counting #25
Open
Photon counting #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -12,29 +12,16 @@ | |||
| from acq4.util.debug import printExc | |||
There was a problem hiding this comment.
These changes should be removed from this branch. You can use rebase -i and skip the merge commit, or I'll do it after the PR is ready to merge.
There was a problem hiding this comment.
Sorry. I am not quite sure how to do it.
git checkout photon-counting
git rebase -i
??
Thanks.
|
Looks great to me! I'm pleased that once you had counter support for the DAQ, the remaining changes appeared to be very simple. |
…and in SuperTask.py
…on the device family, which is queried in configureClocks of Supertask.py.
…only if more than one device is involved.
…igital signal from the photo-multipier - instead of recording the PMT output through the analog input.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.