add const qualifier to static strings (#662) #688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This squelches a compiler warning, but also prevents run-time modification of `kDefaultLoggerId`, `kPerformanceLoggerId`, and `kSysLogLoggerId`
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This squelches a compiler warning, but also prevents run-time
modification of kDefaultLoggerId, kPerformanceLoggerId,
and kSysLogLoggerId.
This is a
Breaking change
New feature
Bugfix
I have
[ Yes ] Merged in the latest upstream changes
[ No ] Updated CHANGELOG.md
This seemed minor bugfix, but will make entry if desired.
[ No ] Updated README.md
[ Yes ] Run the tests
I did run the tests in a test Docker image based on Xenial. I had to add pthread to the target_link_libraries to get them to build (not part of this PR).
I had the same failures between this changeset and master.