Enable reopening log files #595
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Apparently unit test fails, I haven't looked at them yet. Any comment on this change, does it break the architecture? Or is it just the tests that need to be updated? |
bhjortsberg
force-pushed
the
reconfigure-logger
branch
from
04d5c2b
to
20c560d
Compare
|
Tests passes when I run them locally with my latest update. Travis CI build seem to have some problem with cmake when building googletest. |
bhjortsberg
force-pushed
the
reconfigure-logger
branch
from
20c560d
to
fdc76d5
Compare
LogStreamReferenceMap was keeping a reference to FileStream which kept the file open even though Logger was unregistred.
bhjortsberg
force-pushed
the
reconfigure-logger
branch
from
fdc76d5
to
41ef65e
Compare
|
I would love to see this added, as without using the linux |
| if (!needNewStream && filestreamIter->second.lock() == nullptr) { | ||
| // Filestream is expired and exists in map | ||
| needNewStream = true; | ||
| m_logStreamsReference->erase(filestreamIter); |
There was a problem hiding this comment.
There may still be some remaining elements in map that can't be removed
There was a problem hiding this comment.
I don't get that can't be removed.
This erase only one expired file stream.
If it is not expired, why remove?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once a Logger is configured the application keeps the file open. This is due to that
LogStreamReferenceMapis keeping a reference to the FileStream object and unregistering the Logger will never close the file.Switching to weak_ptr in
LogStreamReferenceMapi.e. not holding a reference makes unregistering logger close the file if no other reference to FileStream object exist.The use case is for logrotation where logrotation removes the logfile and sends a SIGHUP to the application. This fix makes it possible to reconfigure the logger to reopen the log file. I added a sample to illustrate the use case.
This is a
I have
CHANGELOG.mdREADME.md