Add support for environment variables resolution in log file names #570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abumq
requested changes
Oct 8, 2017
There was a problem hiding this comment.
This will cause us to lose support for GCC 4.6.4 as regex was implemented in 4.9+ -
see https://gcc.gnu.org/bugzilla/show_bug.cgi?id=53631 => Target Milestone section
Can we please do it without depending on regex as it's not worth losing support for two minor versions of GCC just to add little support for environment variables.
|
Sure, you are right! |
abumq
reviewed
Oct 15, 2017
| @@ -93,7 +93,7 @@ | |||
| #else | |||
| # define ELPP_OS_MAC 0 | |||
| #endif | |||
| #if (defined(__FreeBSD__) || defined(__FreeBSD_kernel__)) | |||
There was a problem hiding this comment.
I think this is some typo, definitely unintended.
|
can you please add test cases as well please? Preferably in TypedConfigurationsTest |
|
Sure, I will! I just was out of time recently, sorry for not answering :3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a
I have
CHANGELOG.mdREADME.mdThe syntax is cmake-like:
E.g., suppose we have ELPP_VAR as environment variable, then configuration file can look like this:
Global:
FORMAT = "%msg"
FILENAME = "matcher_${ELPP_VAR}.log"
ENABLED = true
TO_FILE = true
TO_STANDARD_OUTPUT = true
SUBSECOND_PRECISION = 6
PERFORMANCE_TRACKING = true
MAX_LOG_FILE_SIZE = 2097152 ## 2MB - Comment starts with two hashes (##)
LOG_FLUSH_THRESHOLD = 100 ## Flush after every 100 logs
In case ELPP_VAR is not set, it will be substituted with an empty string.