Improve usability of type annotations with mypy. #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This would allow absl-py users to type-check their code with e.g. mypy.
Because `wasSuccessful()` is not defined within the class, but is "monkey-patched" in, the implicit `self` argument is not correctly typed. Make it explicit for it to be handled correctly.
mypy is strict in wanting the comment before the docs, and will report "invalid syntax" otherwise.
mypy is stricter when it comes to propagation of None values.
gpshead
approved these changes
May 11, 2020
|
Folks will I ever get this one merged in? :) |
lukegb
approved these changes
Oct 4, 2020
|
Friendly ping, can this still be rescued? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes a couple of fixes were mypy appears to be stricter than pytype, and adds PEP 561 markings so that mypy knows that the module contains type information.