Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default known_only to parse_flags_with_usage #120

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sritchie
Copy link

@sritchie sritchie commented Nov 6, 2019

This would allow users to take advantage of the error handling here while still being able to pass custom options on to FLAGS.

An alternative approach would just pass all kwargs along; but there's only one and this allows the docstring to stick here as well.

This would allow users to take advantage of the error handling here while still being able to pass custom options on to FLAGS.

An alternative approach would just pass all `kwargs` along; but there's only one and this allows the docstring to stick here as well.
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@sritchie sritchie closed this Nov 6, 2019
@sritchie sritchie reopened this Nov 6, 2019
@sritchie
Copy link
Author

sritchie commented Nov 6, 2019

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes and removed cla: no labels Nov 6, 2019
@yilei
Copy link
Contributor

yilei commented Nov 6, 2019

Makes sense. Could you please add a unit test, it will need similar setup as this one

@yilei yilei requested review from yilei and gpshead November 6, 2019 19:50
Copy link
Contributor

@yilei yilei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Actually make my reply a proper PR review)

Makes sense. Could you please add a unit test, it will need similar setup as this one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants