App: Added more strings in resources #650
Conversation
| estimated time = %6$s</string> | ||
| <string name="msg_read_wpt_error">Error reading waypoints</string> | ||
| <string name="msg_no_wpt">coordinate source does not contain any waypoints!</string> | ||
| <string name="msg_to_much_wpts">"coordinate source contains too much waypoints: %1$d (please use from/to/via names)</string> |
There was a problem hiding this comment.
The " in "coordinateshould not be needed?
|
@afischerdev very nice, there are a lot of strings! Please use |
Thanks for the suggestion. I started that way but getString with parameter was working as well. |
|
Although the other method is Android specific, Android shows warnings when we build a release apk. |
|
@devemux86 |
|
@afischerdev there are more texts we need to move to
|
| <string name="summary_version">The base version for tiles has changed. What to do?</string> | ||
| <string name="action_version1">Continue with current download, delete other old data</string> | ||
| <string name="action_version2">Select all for download and start</string> | ||
| <string name="action_version3">Cancel now, complete on an other day</string> |
There was a problem hiding this comment.
Should be "another" day?
| <string name="summary_version_diff">The base version for some tiles is different. What to do?</string> | ||
| <string name="action_version_diff1">Download all different tiles</string> | ||
| <string name="action_version_diff2">Drop all different tiles</string> | ||
| <string name="action_version_diff3">Cancel now, complete on an other day</string> |
There was a problem hiding this comment.
Should be "another" day?
| <string name="msg_download_failed">Download failed</string> | ||
| <string name="msg_download_cancel">Download cancelled</string> | ||
| <string name="msg_download_succeed">Download succeeded</string> | ||
| <string name="msg_download_started">"Downloading .. "</string> |
There was a problem hiding this comment.
The quotes here are not needed?
| @@ -1,7 +1,7 @@ | |||
| <?xml version="1.0" encoding="utf-8"?> | |||
| <resources xmlns:tools="http://schemas.android.com/tools"> | |||
| <plurals name="numberOfSegments" tools:ignore="MissingQuantity"> | |||
| <item quantity="one">%d τμήμα</item> | |||
| <item quantity="one">%d τμήμα</item>compare cl | |||
There was a problem hiding this comment.
The "compare cl" is error here, we must remove it.
Moved more hardcoded strings to resource.
Initial pull request was #645
Please note: this contains no translations.