Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

A Dockerfile #647

Merged
merged 5 commits into from Jan 17, 2024
Merged

A Dockerfile #647

merged 5 commits into from Jan 17, 2024

Conversation

joe-akeem
Copy link
Contributor

So brouter can be run in Docker 馃槂

Copy link
Collaborator

@afischerdev afischerdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not firm with Docker, but it looks ok for like it is.

Only I miss is a call for 'generate_profile_variants.sh'

@joe-akeem
Copy link
Contributor Author

joe-akeem commented Jan 16, 2024

@afischerdev the script was already run by the gradle build but the generated profiles were not used. I updated the Dockerfile and the documentation. Now, if you start the container without mounting a profiles folder, it will use the default profiles including the variants. If you do mount a folder containing custom profiles, it will replace the one with the default profiles. What do you think?

@afischerdev
Copy link
Collaborator

@joe-akeem
Thanks for the description, meanwhile I have run the docker build and get the server run.
So I've seen what docker is doing. I'm working on a Windows system, so the profile variant builder script doesn't work, but that is not relevant for docker.

BTW for running it on Windows I had to invalidate the first line of gradlew and server.sh

Copy link
Collaborator

@afischerdev afischerdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine, I think.

@afischerdev afischerdev merged commit d2e183c into abrensch:master Jan 17, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants