Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App version check #526

Merged
merged 2 commits into from Apr 14, 2023
Merged

Conversation

afischerdev
Copy link
Collaborator

According to @polyscias update lookups comment a app version check is added.

Rework of the handling if profile param is used.

@afischerdev afischerdev temporarily deployed to BRouter April 4, 2023 09:52 — with GitHub Actions Inactive
Copy link
Contributor

@polyscias polyscias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking this up. I am no Java programmer but as far as I can check the changes look good to me.

The usefulness for this is for the coming profile update maybe limited but if this functionality would have been in from the start, a non-compatible profile update would have been less error prone.

I would like to give this code a test (maybe next weekend) and see how it works but I think it would be good to do a release of the App soon after this has been checked in and the profile update only later.

@afischerdev
Copy link
Collaborator Author

I think it would be good to do a release of the App soon after this has been checked in and the profile update only later.

Thanks for the test. Yes, I also think app first.

@afischerdev
Copy link
Collaborator Author

@polyscias
Could you do some tests?
It is hard to test when there is no server to download a new and changed lookups.dat
For this situation I used this logic:
When downloaded a new lookups.dat from server it is first stored in a file named lookups.dat.tmp
And then the checks are done.
You could transfer a manipulated tmp file from PC and then start BRouter download dialog.
When there already is a tmp file this is checked.
Current version code is 45

@polyscias
Copy link
Contributor

I could not find time this long weekend and yesterday did build the brouter App with the patch. Now trying to test it with a servconfig.txt file pointing to my own web server with some test files but that needs still some debug, will update once I have results.

Not sure how much time I have coming days, so better not wait for me if you want to continue.

@afischerdev afischerdev merged commit 575c24c into abrensch:master Apr 14, 2023
1 check passed
@afischerdev afischerdev deleted the app-version-check branch April 14, 2023 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants