New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update lookups #458
base: master
Are you sure you want to change the base?
Update lookups #458
Conversation
If we generate new segments using this update
|
Yes. When the server update is done and an apk user updates the data lookups.dat and profiles are downloaded first then rd5 download starts. But when user has called e.g. only one rd5 but has 4 on board he has a problem when next enter an outdated rd5 - he will get a notice.
When index changes a new number is needed. Smaller changes like aliases don't change it.
Yes, until new apk version is out. Current looks for hiking-beta |
I think breaking things for (many) users is bad and like I wrote in #416, I see quite some pain for removing oneway=true. I did post PR to update the profiles of @poutnik, see poutnikl/Trekking-Poutnik/pull/30 but that has not been merged as of now. Apart from the profiles of @poutnik it also impacts most other profiles so I think it is better to keep it in the profile for now, but let's remove it for the brouter profiles.
How does that notice look like? Also, what about return meta.lookupVersion == 10; For the remainder the patch looks good to me, I can run later this weekend a map generation run with it and give some stats. |
Quoting @polyscias from #416 (comment):
I wondered where the The OSM tag history graph (see also Taginfo chronology) looks suspicious: And indeed, there are two unique uses:
The latter and other sporadic edits are all using the iD editor, which actually has that value in the list of suggestions when using the properties table, which is most probably because of the value count of that single import. Therefore I think the [1] curl -o changeset-21660337.osc https://www.openstreetmap.org/api/0.6/changeset/21660337/download
grep "grade3-5" changeset-21660337.osc | wc -l |
Nice analysis @nrenner! I am perfectly fine with removing the grade3-5 alias but my opinion is, also with knowing this story, such an alias is fine. There are more tags in lookups.dat that are undocumented, for instance noexit=yes in way context and junction=approach |
I have somehow missed the PR and related discussion. I will try to address it and generate new profiles, but after Aug 15, due vacation. Another delay will be for LocusMap users, with profiles embedded to application or online LocusMap client. They use profiles from several sources. |
That would be nice.
Do you have some more information on this, in particular the exact profiles that are used? I like to add them to my collection of profile that I check for impact of this update.
With quite some delay I did run it and looking at all the .rd5 files generated versus those on http://brouter.de/brouter/segments4/ The extremes:
I am planning to get the updated lookup.dat, profiles and one .rd5 on my mobile and see what it does. |
See also brouter-web#669, can we add also:
The first two are accessible on foot and a pier is often a way to access a ferry both on foot and by bicycle. |
@quaelnix |
I guess we should not only support |
Hi, if I understand well, to use these new tags in Brouter, the RD5 tiles must be regenerated with this new lookup file. The additions are very interesting for my use case. Thanks for your work ! Is there a "next" branch where RD5 files are already available ? |
Afaik not. |
Hi, I read the previous discussion and the related issue #416 but I am unclear on what is needed for these lookup updates to be able to be merged and to be available in brouter web and other brouter based use cases? |
To all friends of profiles: Please keep in mind for testing your profiles against a new/changed
|
This is the call for a bigger update on lookups.dat
The Android apk doesn't need an update for that. Lookups.dat and profiles are updated automaticly.
Next apk update will then contain the new versions.
So only web services are affected.
And an update for the profiles is needed when there is an interest on man_made=pier or other changes.
Please see #416 for more.