[WIP] Unified test suite: prototype interception proxy #1737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lawrence-forooghian
force-pushed
the
ECO-14-document-internal-api-use-in-tests
branch
29 times, most recently
from
f781da0
to
b04ffc9
Compare
lawrence-forooghian
force-pushed
the
ECO-14-document-internal-api-use-in-tests
branch
from
17866d7
to
1a4fa36
Compare
github-actions
bot
temporarily deployed
to
staging/pull/1737/bundle-report
lawrence-forooghian
force-pushed
the
ECO-14-document-internal-api-use-in-tests
branch
from
0074685
to
7e93dbb
Compare
github-actions
bot
temporarily deployed
to
staging/pull/1737/bundle-report
lawrence-forooghian
force-pushed
the
ECO-14-document-internal-api-use-in-tests
branch
from
7e93dbb
to
3efb313
Compare
github-actions
bot
temporarily deployed
to
staging/pull/1737/bundle-report
lawrence-forooghian
force-pushed
the
ECO-14-document-internal-api-use-in-tests
branch
3 times, most recently
from
0baae01
to
a96b2d0
Compare
lawrence-forooghian
changed the base branch from
main
to
ECO-4786-document-private-API-usage
lawrence-forooghian
force-pushed
the
ECO-14-document-internal-api-use-in-tests
branch
from
a96b2d0
to
949e2e6
Compare
lawrence-forooghian
changed the title
lawrence-forooghian
force-pushed
the
ECO-4786-document-private-API-usage
branch
from
812851e
to
28523ba
Compare
For upcoming interception proxy. TODO: once I’ve got rid of the subsequent commit with the old Python code, put this into the later commit instead
Implemented entirely as an mitmproxy addon. Abandoned because it didn’t give me sufficient control over WebSocket connection lifetimes.
This reverts commit 27c5272. (I just want to keep it in the Git history for now, in case for some reason it’s useful to return to.)
…prototype - start-interception-proxy adapted from https://github.com/ably/sdk-test-proxy at 82e93a7 Some TODOs which aren’t really important right now because this is just a prototype: - TODO fix type checking for interception proxy — `npm run build` does it properly, but tried to reproduce the way we do it for modulereport and it didn’t work - TODO fix linting for interception proxy — doesn’t seem to be catching lint errors - TODO linting / type checking etc for Python code - TODO investigate test failures in browser: - Firefox is passing - [Chromium is failing](https://github.com/ably/ably-js/actions/runs/8802125604/job/24157087173): > ``` > [](https://github.com/ably/ably-js/actions/runs/8802125604/job/24157087173#step:15:35514)- offers realtime presence functionality > > [](https://github.com/ably/ably-js/actions/runs/8802125604/job/24157087173#step:15:35515)- is able to use the web_socket transport > > [](https://github.com/ably/ably-js/actions/runs/8802125604/job/24157087173#step:15:35516)- is able to subscribe to and unsubscribe from channel events, as long as a MessageFilter isn’t passed > > [](https://github.com/ably/ably-js/actions/runs/8802125604/job/24157087173#step:15:35517)- can take a MessageFilter argument when subscribing to and unsubscribing from channel events > ``` > - [WebKit is failing](https://github.com/ably/ably-js/actions/runs/8802125604/job/24157087922): > ``` > failed tests: > > [](https://github.com/ably/ably-js/actions/runs/8802125604/job/24157087922#step:15:27042)- allows you to use push admin functionality > > [](https://github.com/ably/ably-js/actions/runs/8802125604/job/24157087922#step:15:27043)- allows you to use push admin functionality > ``` TODO update the above failures, they _should_ be all fixed now, but I don’t know if sandbox is currently having a wobble or something Also: > Add test:playwright:open-browser script > > Lets you open a headed browser which is configured to use the > interception proxy. Useful for local debugging of browser tests.
lawrence-forooghian
force-pushed
the
ECO-14-document-internal-api-use-in-tests
branch
from
949e2e6
to
53326f2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.