bug fixes for chrome under unity (ubuntu) #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kadaj : Thanks for the PR. I am busy with several other stuff right now, so won't have chance to review it immediately (btw, at the minimum I would like to have the commits squshed into one, but I will reply with other comments when I get chance for a proper review). Also I am little concerned about special casing for a lot of different platforms, so would like to think about a possible way to handle them more generically. |
|
@abiyani I have squashed the commits and made it more generic. Removed OS specific version check and used |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug fixes for chrome under unity (ubuntu): removes the command popup, removes switching to text mode. Fixes issue #11 .