Update package.json [Bug fixing] #176
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[error message]: The package may have incorrect main/module/exports specified in its package.json [solution]: "browser": "dist/jsmediatags.min.js", [Description]: In the package.json, the browser is supposed to have a "browser": "dist/jsmediatags.min.js", and not "browser": "dist/jsmediatags.js" to work well in the browser.
|
Thanks for making jsmediatags! I ran into the same problem and can confirm that the change in this PR fixes it. With this fix, I can just do |
|
Please, merge it |
|
Will fix #172 when merged, bumping. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[error message]: The package may have incorrect main/module/exports specified in its package.json
[solution]: "browser": "dist/jsmediatags.min.js",
[Description]: In the package.json, the browser is supposed to have a "browser": "dist/jsmediatags.min.js", and not "browser": "dist/jsmediatags.js" to work well in the browser.