Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix:Comments in .py files #30

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

SahanChan
Copy link

Gave some life to the python code by adding comments.
;-)

@zircher
Copy link

zircher commented Oct 27, 2019

Just curious, has this been tested under 2.8?

@SahanChan
Copy link
Author

Just curious, has this been tested under 2.8?

Yeah, it is tested, they are just comments.
XD

@ldo
Copy link

ldo commented Jan 20, 2022

My policy with comments is they should explain why you are doing something, rather than simply repeating what the code is doing.

For example, from my version:

def define_tex_coords_common() :
    # creates a node group that defines a common coordinate system
    # for all my image textures.
    ...

def define_hull_colour_common() :
    # creates a node group that applies the grunge factor to
    # an input colour to produce an output colour.
    ...

def define_normals_common() :
    # defines a node group for the normal-mapping texture to be used
    # across different hull materials.
    ...

etc, etc.

@SahanChan
Copy link
Author

Yup you are right :))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants