避免跳过一个正常的ts包 #2423
Open
避免跳过一个正常的ts包 #2423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
最好对比下性能吧 这个是高频操作。 |
|
好的, 我明天做一个详细的性能测试
夏楚 ***@***.***> 于2023年4月26日周三 14:32写道：
… 最好对比下性能吧 这个是高频操作。
hls/ts这块我觉得你全权负责算了 我就不本地测试验证了
—
Reply to this email directly, view it on GitHub
<#2423 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AF3RPRNOPWFPGBXUCKAL7ULXDC6QTANCNFSM6AAAAAAXLY6QU4>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
xia-chu
force-pushed
the
master
branch
4 times, most recently
from
efa46df
to
22732ea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
想了想, 虽然你直接操作内存会比较高性能, 但是与反复遍历整个大循环想比直接在这里寻找下一个包头会让代码更加清晰, 降低阅读代码时的心智负担, 所以还是提交了这个修改.
你看下是否合适, 如果不合适就还是按照你的方式修改, 还是使用memchr来寻找并再次循环onSearchPacketTail