Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose credential public key as a PublicKey object #299

Merged
merged 5 commits into from
Jul 3, 2023

Conversation

iaik-jheher
Copy link
Contributor

As discussed in #288; this allows consumers to handle the credential's public key without needing specific CBOR/COSE logic.

I considered @Getter(lazy=true)-based caching, but ended up deciding against it for three reasons:

  • Decoding will likely not be performed by many consumers
  • Decoding is a very fast operation
  • Decoding may throw

@emlun emlun self-assigned this Jun 22, 2023
@emlun
Copy link
Member

emlun commented Jun 27, 2023

Thanks, I finally have time to properly dig into these. I'll make some small modifications but this looks good to me!

Would you like to be credited in the release notes? If yes, would you prefer by real name or by GitHub username?

@iaik-jheher
Copy link
Contributor Author

Sure, I'd appreciate that if you think it appropriate. I'll have to check with my employer about details; I'll get back to you on that.

@iaik-jheher
Copy link
Contributor Author

We'd prefer attribution to take the form Jakob Heher (A-SIT) if possible. Thanks for offering!

@emlun emlun changed the base branch from main to release-2.6.0 June 28, 2023 08:32
@emlun emlun merged commit 7c8fd3b into Yubico:release-2.6.0 Jul 3, 2023
10 checks passed
@iaik-jheher iaik-jheher deleted the feature/expose-public-key branch March 6, 2024 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants