Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub actions to remove outdated patches/revisions #101

Open
sifferman opened this issue Feb 3, 2024 · 0 comments
Open

GitHub actions to remove outdated patches/revisions #101

sifferman opened this issue Feb 3, 2024 · 0 comments

Comments

@sifferman
Copy link
Contributor

Hello!

It is my opinion that this project is most helpful when it delivers as close to the latest unmodified version as possible. Many untracked patches/revision freezes will make that goal difficult.

#89 and #100 remove outdated patches for Verilator. I've noticed there are dozens of patches across many different tools, as well as many tool versions that are frozen at a specific revision. It seems fairly challenging to keep track of outdated patches/revision freezes.

Would it be possible to add some automatic testing on whether a patch/revision freeze is still necessary? I imagine this can be achieved with attaching a test to every patch:

  1. Every patched project should be built twice: once with the patch, and once without
  2. A test is run on both the patched and unpatched versions
Unpatched Passes Unpatched Fails
Patched Passes ALERT "Patch no longer needed" (no alert, patch working as intended)
Patched Fails ALERT "Patch breaks compatibility" ALERT "Patch insufficient"

I bring this up, because I see that Icarus' revision was just frozen d22858d, although it gets frequent updates that are very helpful for users. I would like to see some automatic testing for when the revision can be unfrozen.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant