add option for clearance in all directions #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The existing implementation of clearance only checks for obstacles along one diagonal. This works for the problem as defined in the reference material, but it is not suitable for situations where one needs to check for clearance in a radius around the walkable point. To address that need, this PR adds an option to check for clearance in all directions. This change is backwards-compatible and preserves the existing check as the default behavior.
|
for those wondering it seems this PR was merged |
|
Apparently not, according to the commit log. See related comment on PR 63. |
|
that is weird because in my version of jumper your PR is present! The author was posting his progress on some forum (Gideros in my case) and I may have got an updated version different from GH! sorry for the inconvenience! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing implementation of clearance only checks for obstacles along one diagonal. This works for the problem as defined in the reference material, but it is not suitable for situations where one needs to check for clearance in a radius around the walkable point. To address that need, this PR adds an option to check for clearance in all directions. This change is backwards-compatible and preserves the existing check as the default behavior.