Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

en_US Translations Pruning & Reorganization #155

Merged
merged 3 commits into from
May 13, 2024

Conversation

rkwapisz
Copy link
Contributor

@rkwapisz rkwapisz commented May 12, 2024

Compares done on latest master repos of Translations and YimMenu on 5/12/2024 2:00pm PST.

There are a few issues with the YimMenu translations file(s):

  • Updates to YimMenu features aren't always flowed into the translations repo which leaves dangling translation entries that may confuse contributors and users into thinking certain removed features still exist
  • Contributors have had a tendency to create new keys instead of reusing existing ones, adding to overall bloat
  • Keys haven't been strictly managed in alphabetical order, increasing the likelihood of unneeded duplicates in the future and making navigation more difficult

This PR attempts to clean up the en_US translations file by:

  1. Removing translation keys from en_US.json that are unused in YimMenu .cpp and .hpp files strictly within the YimMenu project directory structure (some references may remain in other files such as readmes)

  2. Organizes en_US.json in ascending key alphabetical order.

Closes #148

Update en_US.json
@rkwapisz
Copy link
Contributor Author

False detection on the GUI TAB keys. Updating shortly.

@gir489returns
Copy link
Contributor

Confirmed, the translation are now lexically correct.

gir489returns
gir489returns previously approved these changes May 13, 2024
@gir489returns gir489returns merged commit de245c8 into YimMenu:master May 13, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Suggestion] Translation Table Cleanup
2 participants