Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flying Axe Translation #134

Merged
merged 2 commits into from
May 24, 2024
Merged

Flying Axe Translation #134

merged 2 commits into from
May 24, 2024

Conversation

Rxann
Copy link
Contributor

@Rxann Rxann commented Apr 12, 2024

No description provided.

rkwapisz
rkwapisz reviewed Apr 14, 2024
View reviewed changes
Copy link
Contributor

@rkwapisz rkwapisz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should move BACKEND_LOOPED_FLYING_AXE just before BACKEND_LOOPED_HUD_TRANSITION_STATE_CANCEL_JOINING to maintain alphabetical order.

@rkwapisz
Copy link
Contributor

You can also add a translation for "BACKEND_LOOPED_FLYING_AXE_DESC".

I personally like "Summons a deadly swirling axe around you that causes chaos and destruction."

"BACKEND_LOOPED_FLYING_AXE_DESC": "Summons a deadly swirling axe around you that causes chaos and destruction.",

Yimura
Yimura requested changes May 2, 2024
View reviewed changes
Copy link
Member

@Yimura Yimura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing BACKEND_LOOPED_FLYING_AXE_DESC and see comments from @rkwapisz.

@Rxann Rxann requested a review from Yimura May 3, 2024 22:10
@Rxann
Copy link
Contributor Author

Rxann commented May 3, 2024

@rkwapisz thank you for the assistance with the translations.

@Yimura i have added a translation for #2973 where the player pointer is null. I will open a pr on YimMenu once this is merged.

@Rxann Rxann mentioned this pull request May 22, 2024
Merged
@Yimura Yimura merged commit dfd6cfe into YimMenu:master May 24, 2024
@Rxann Rxann deleted the axe branch May 24, 2024 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rkwapisz rkwapisz rkwapisz left review comments

@Yimura Yimura Yimura approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Rxann @rkwapisz @Yimura