Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added plus-versions of themes with active color, active & modified color and inactive & modified color #104

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

maxxst
Copy link

@maxxst maxxst commented Jun 24, 2015

Because I'm still playing a little bit with the master branch I created a dedicated pull request branch

Like I mentioned in #102 I created plus versions for your themes that have some new behavior:

  1. main color indicates active tabs
  2. there are secondary and tertiary colors for active & modified and inactive & modified

Here some screenshots to show what I mean:

afterglow-blue

afterglow-blue -modified

(assets.json is changed but not saved)

blue+

a    : blue
a + m: purple
i + m: magenta

green+

a    : green
a + m: orange
i + m: magenta

magenta+

a    : magenta
a + m: orange
i + m: blue

orange+

a    : orange
a + m: blue
i + m: magenta

@YabataDesign
Copy link
Owner

@maxxst, Thank you very much for your contribution.

I need time to carefully review the code and improvements. Now I have a lot of work, so you must be patient.

Thanks so much.

@maxxst
Copy link
Author

maxxst commented Jun 25, 2015

@YabataDesign no worries :)

I really love your theme and I'm able to use it with my additions already. So no pressure from my side.
If I can do anything to support you just say so :)

@maxxst
Copy link
Author

maxxst commented Sep 4, 2015

any updates on this ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants