Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for AMD ROCm devices #123

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Conversation

Junyi-99
Copy link

Issue Type

  • Feature implementation

Description

I've implemented ROCm support in nvitop, enabling it to run on AMD GPUs. This feature has been tested on mi50, mi100, and mi210 machines and is confirmed to maintain full functionality for NVIDIA GPUs.

Motivation and Context

Really need nvitop on AMD GPUs.

#74

Testing

Tested on

mi50

mi100

mi210

Images / Videos

mi100

(top: nvitop, bottom-left: rocm-smi, bottom-right: pytorch code)

@XuehaiPan XuehaiPan self-assigned this Mar 13, 2024
@XuehaiPan XuehaiPan added enhancement New feature or request api Something related to the core APIs labels Mar 13, 2024
@XuehaiPan XuehaiPan linked an issue Mar 13, 2024 that may be closed by this pull request
2 tasks
@XuehaiPan
Copy link
Owner

XuehaiPan commented Mar 15, 2024

Hi @Junyi-99, thanks for the contribution! Is there any PyPI package that provides the ROCm-SMI bindings like nvidia-ml-py for the NVIDIA NVML library? Maybe we should ship the ROCm support with:

pip3 install nvitop[rocm]

@Junyi-99
Copy link
Author

Oh, I think it's a very good suggestion to ship through nvitop[rocm]. Currently, there is a ROCm binding, but it is not that functional.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Something related to the core APIs enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] Add support to AMD's ROCm GPU
2 participants