Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend XRFDC driver for MTS support #1384

Open
wants to merge 5 commits into
base: image_v3.1
Choose a base branch
from

Conversation

dspsandbox
Copy link

  • MTS logic and documentation included in xrfdc driver
  • Update xrfclk driver documentation (was outdated)
  • Add LMK04208 config files for 128MHz and 258MHz (useful for MTS on ZCU111)

@schelleg
Copy link
Collaborator

hi @dspsandbox - thank you for this nice contribution...

could you remove the .so file? We rebuild that as part of the sdbuild process.

we are about to release v3.0 and would like to accept this right after in a image_v3.1 branch ... at that point, we'll be able to evaluate and commit on top if we see any issue with a 2022.1 build

@codecov-commenter
Copy link

Codecov Report

Merging #1384 (6204053) into image_v2.8 (59515a9) will decrease coverage by 1.11%.
The diff coverage is n/a.

@@              Coverage Diff               @@
##           image_v2.8    #1384      +/-   ##
==============================================
- Coverage       46.47%   45.35%   -1.12%     
==============================================
  Files              28       29       +1     
  Lines            4953     5137     +184     
  Branches          971     1036      +65     
==============================================
+ Hits             2302     2330      +28     
- Misses           2594     2748     +154     
- Partials           57       59       +2     
Impacted Files Coverage Δ
pynq/utils.py 23.57% <0.00%> (-0.55%) ⬇️
pynq/pl_server/hwh_parser.py 17.24% <0.00%> (-0.41%) ⬇️
pynq/overlay.py 33.48% <0.00%> (-0.16%) ⬇️
pynq/ps.py 100.00% <0.00%> (ø)
pynq/lib/__init__.py 100.00% <0.00%> (ø)
pynq/_3rdparty/xclbin.py 100.00% <0.00%> (ø)
pynq/pl_server/xclbin_parser.py 0.00% <0.00%> (ø)
pynq/pl_server/embedded_device.py 0.00% <0.00%> (ø)
pynq/lib/debugbridge.py 10.86% <0.00%> (ø)
pynq/pl_server/xrt_device.py 29.48% <0.00%> (+0.30%) ⬆️
... and 1 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@dspsandbox
Copy link
Author

Happy to hear that @schelleg,
I have just update the PR.
Best regards,
Pau

@schelleg schelleg changed the base branch from image_v2.8 to image_v3.1 May 1, 2024 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants