New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MMIO enhancements to support read and write using different datatype #1367
Closed
mariodruiz
wants to merge
20
commits into
Xilinx:image_v2.8
from
mariodruiz:image_v2.8.mmio_enhancements
Closed
MMIO enhancements to support read and write using different datatype #1367
mariodruiz
wants to merge
20
commits into
Xilinx:image_v2.8
from
mariodruiz:image_v2.8.mmio_enhancements
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## image_v2.8 #1367 +/- ##
==============================================
- Coverage 46.49% 46.45% -0.05%
==============================================
Files 28 28
Lines 4955 4960 +5
Branches 971 973 +2
==============================================
Hits 2304 2304
- Misses 2594 2599 +5
Partials 57 57
Continue to review full report at Codecov.
|
Maintaining MMIO API through next release - closing for now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support different datatypes for MMIO read and write.
word_order
andlength
are deprecatedmmio.read(offset,dtype=np.float)
, default is intFix #634