Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MMIO enhancements to support read and write using different datatype #1367

Closed

Conversation

mariodruiz
Copy link
Collaborator

Support different datatypes for MMIO read and write.

  • Merge write functionality in a single method
  • MMIO.read arguments word_order and length are deprecated
  • MMIO.write detects datatype automatically
  • MMIO.read returns the datatype based on the dtype keyword (**kwargs). Eg. mmio.read(offset,dtype=np.float), default is int

Fix #634

@mariodruiz mariodruiz requested a review from schelleg June 17, 2022 13:02
@codecov-commenter
Copy link

codecov-commenter commented Jun 17, 2022

Codecov Report

Merging #1367 (308396a) into image_v2.8 (0cdf6b9) will decrease coverage by 0.04%.
The diff coverage is 95.00%.

@@              Coverage Diff               @@
##           image_v2.8    #1367      +/-   ##
==============================================
- Coverage       46.49%   46.45%   -0.05%     
==============================================
  Files              28       28              
  Lines            4955     4960       +5     
  Branches          971      973       +2     
==============================================
  Hits             2304     2304              
- Misses           2594     2599       +5     
  Partials           57       57              
Impacted Files Coverage Δ
pynq/overlay.py 33.63% <0.00%> (ø)
pynq/mmio.py 100.00% <100.00%> (ø)
pynq/pl_server/xrt_device.py 29.53% <0.00%> (+0.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0cdf6b9...308396a. Read the comment docs.

@schelleg
Copy link
Collaborator

schelleg commented May 1, 2024

Maintaining MMIO API through next release - closing for now

@schelleg schelleg closed this May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mmio.write() does not accept numpy.uint32 as type of data argument
3 participants