Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support numpy and float data types in MMIO read/write #1332

Closed

Conversation

mariodruiz
Copy link
Collaborator

  • Support for write/read floating point numbers
  • Support for write/read numpy.uint32 and numpy.int32 numbers. Fix mmio.write() does not accept numpy.uint32 as type of data argument #634
  • Merge write functionality in a single method
  • MMIO.read arguments word_order and data_type are passed as keywords (**kwargs)
  • Update test cases to verify new data types read/write operations

@codecov-commenter
Copy link

codecov-commenter commented Feb 1, 2022

Codecov Report

Merging #1332 (2e8b909) into image_v2.8 (b85f453) will decrease coverage by 0.07%.
The diff coverage is 92.85%.

Impacted file tree graph

@@              Coverage Diff               @@
##           image_v2.8    #1332      +/-   ##
==============================================
- Coverage       46.47%   46.40%   -0.08%     
==============================================
  Files              28       28              
  Lines            4953     4950       -3     
  Branches          971      971              
==============================================
- Hits             2302     2297       -5     
- Misses           2594     2595       +1     
- Partials           57       58       +1     
Impacted Files Coverage Δ
pynq/mmio.py 97.46% <92.30%> (-2.54%) ⬇️
pynq/overlay.py 33.63% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b85f453...2e8b909. Read the comment docs.

@mariodruiz mariodruiz marked this pull request as draft February 14, 2022 09:39
@schelleg schelleg added the draft label Feb 23, 2022
@mariodruiz mariodruiz closed this Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants