add aortic_valve.cpp #290
add aortic_valve.cpp #290
Conversation
|
@yuanjiajy you do not need to close the pull request, just transfer it draft request. |
|
CI need pass before merge. |
|
You are supposed not change the library directly. |
|
I guess the problem is due to the library libx11-dev and freeglut3-dev, may be some others, should be install first. |
| libx11-dev \ | ||
| freeglut3-dev \ |
There was a problem hiding this comment.
Those dependencies are really orthogonal to this library. (opencascade requires actually libgl-dev rather than freeglut3-dev). If there is no lighter CAD kernel you can use for the purpose, I would recommend to contribute to vcpkg to modularize the opencascade installation, or use the FetchContent mechanism in this repo to get the TKSTEP target without spurious pieces.
There was a problem hiding this comment.
Actually it doesn't work when i only install the libgl-dev, so i install libgl-dev and freeglut3-dev.
There was a problem hiding this comment.
Yes, it doesn't work because the whole of opencascade is installed without distinction, including optional features relying on freeglut. As mentioned in my previous comment, you would need to modularize the vcpkg port to avoid installing everything, or rely on CMake FetchContent mechanism to only build and link TKSTEP.
| find_package(OpenCASCADE CONFIG REQUIRED) | ||
| target_link_libraries(sphinxsys_core INTERFACE TKSTEP ) |
There was a problem hiding this comment.
The module relying on occt should be independent so that the user can choose to enable or disable it with an option
| Vec3d OcctToEigen(const gp_Pnt &occt_vector) | ||
| { | ||
| return Vec3d(occt_vector.X(), occt_vector.Y(), occt_vector.Z()); | ||
| } | ||
| //=================================================================================================// | ||
| gp_Pnt EigenToOcct(const Vec3d &eigen_vector) | ||
| { | ||
| return gp_Pnt(eigen_vector[0], eigen_vector[1], eigen_vector[2]); | ||
| } | ||
| //=================================================================================================// | ||
| Vec3d OcctVecToEigen(const gp_Vec &occt_vector) | ||
| { | ||
| return Vec3d(occt_vector.X(), occt_vector.Y(), occt_vector.Z()); | ||
| } | ||
| //=================================================================================================// |
There was a problem hiding this comment.
Please move things out of src/shared to keep occt bounded out of the core lib at the moment
There was a problem hiding this comment.
Please move things out of
src/sharedto keep occt bounded out of the core lib at the moment
Yes i have removed things to the extra source part in the new pull request
Yes and I have changed it |
No description provided.