-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor devcontainer 📦 #329
Conversation
@ziofil, I've readded oh-my-zsh to the container as default terminal |
# Conflicts: # .devcontainer/Dockerfile # .devcontainer/post-install.sh
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Context:
Doing some housekeeping here on the devcontainer side.
Description of the Change:
juliacall
, meaning there is no need for passing the optionalJULIA_INSTALL
arg todocker build
.MRMUSTARD_PYTHON_VERSION
env-var set in their local environment to dictate which python version the dev container will be built with. When unset, the default value is 3.10. I'd suggest doing this in yourbashrc/zshrc/whatever-rc
to ensure it's always set and therefore picked up by VS CodeBenefits:
Possible Drawbacks:
None. I tried getting the
MRMUSTARD_PYTHON_VERSION
supported in GitHub Codespaces, but it doesn't seem to take any custom build args 😢