Implement issue #1247 #1269
Open
Implement issue #1247 #1269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix issue WowUp#1247 Add an option in the WoW clients options to hide a specific WoW client from the My Addons and Get Addons pages.
linaori
reviewed
Jun 12, 2022
| @@ -46,13 +46,16 @@ export class ClientSelectorComponent implements OnInit { | |||
|
|
|||
| private async mapInstallations(installations: WowInstallation[]): Promise<WowInstallation[]> { | |||
| let total = 0; | |||
| for (const inst of installations) { | |||
|
|
|||
| const displayedInstallations: WowInstallation[] = installations.filter((i) => !i.isHidden); | |||
There was a problem hiding this comment.
We'll probably need a migration to set everything to isHidden = false, but I don't know how that should be added. @jliddev is that something you can explain or add later? Without the migration every client will suddenly be hidden.
There was a problem hiding this comment.
isHidden is optional and will be considered "false" if not present. So every client should be displayed by default and hidden only if manually set to in the options
There was a problem hiding this comment.
Ah my bad, it's the double negative
|
We should probably also ignore update checks and notifications if the client is hidden? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an option in the WoW clients options to hide a specific WoW client from the My Addons and Get Addons pages.