Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Browser Chrome Proportions & Responsive Display #1242

Open
wants to merge 10 commits into
base: trunk
Choose a base branch
from

Conversation

0aveRyan
Copy link
Contributor

@0aveRyan 0aveRyan commented Apr 14, 2024

What is this PR doing?

  • 📰 Update fonts to (largely) use system font stacks.
  • 📐 Improves sizing and proportion of chrome to be smaller and better-reflect real-world OS proportions.
  • ↔️ Improves responsive collapse of Playground when not in fullscreen/seamless.
  • 🔴 Adds reset site functionality (with warning dialog) to red close slot
  • ↕️ Add arrow hover-states to buttons
  • 👀 Wrap pulsing browser animation in check for prefers reduce motion and fallback to box shadow.

What problem is it solving?

  • Helps browser chrome be more-accurate and take up fewer pixels at all screen sizes
  • Helps playground collapse better at mobile viewports
  • Small improvements for cross-platform/browser render and respecting motion preferences.

old chrome screenshot
new chrome screenshot
Button hover states

Copy link
Collaborator

@bgrgicak bgrgicak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @0aveRyan! I left one comment related to the default storage, but otherwise it all looks good.

@bgrgicak bgrgicak self-requested a review April 16, 2024 04:54
Copy link
Collaborator

@bgrgicak bgrgicak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adamziel how does the improved bar look to you?

Copy link
Collaborator

@bgrgicak bgrgicak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@0aveRyan there are a few linter issues that need fixing.

…o improve/browser-chrome-proportions-and-display
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants