Serve file as PHP if a static file wasn't found #1203
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this @bgrgicak . I am still eager to meet with you on slack. Unfortunately I am out of time to meet with you today. I got behind on marking and need to get caught up. Maybe Wednesday? |
|
@rhildred I can't on Wednesday. Would you mind sending me a DM on Slack and we can find a time there? |
bgrgicak
commented
Apr 9, 2024
| return await this.#dispatchToPHP(request, requestedUrl); | ||
| if (this.#isStaticFile(fsPath)) { | ||
| return this.#serveStaticFile(fsPath); | ||
| } else if (this.#isStaticWpCoreFile(fsPath)) { |
There was a problem hiding this comment.
We shouldn't have WordPress-specific code in PHP-wasm but I'm not sure how to resolve this.
I think that the best solution would be to catch this in service-worker and not even trigger the request handler.
The problem is that service-worker can't check if the file exists, so we would need to have a list of available core files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1186
What is this PR doing?
What problem is it solving?
How is the problem addressed?
Testing Instructions