New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Blueprints: add unit tests to the rmdir step #1021
base: trunk
Are you sure you want to change the base?
Conversation
All tests pass, but there is some unexpected behavior. An error is printed out. I don't think this should be the case. Also, a different test which also tests an error-throwing scenario passes without any stack trace being printed out. It implies an error is thrown and somehow not properly handled by the What is more, it properly asserts the error message is as expected. But still prints the thing. I see this behavior in other tests, but it still seems wrong. The print:
|
Nice find, that's an issue with the BasePHP API. There are two ways forward here. Either:
|
Adds tests to the rmdir step.
Related to #756