Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Post Template block: 'List view' display setting should be selected by default #61574

Open
wants to merge 2 commits into
base: trunk
Choose a base branch
from

Conversation

hbhalodia
Copy link
Contributor

@hbhalodia hbhalodia commented May 10, 2024

Fixes #61569

What?

Why?

  • This PR adds the List View as default for the post template block.

How?

  • On checking, we identified that, Layout is coming as an attribute inside the post template block. We checked if that is undefined, set it as the default list view.

Testing Instructions

  • Open, any page.
  • Add the query loop block and select any pattern.
  • You would see now the list view is by default selected for that pattern.

Testing Instructions for Keyboard

  • NIL

Screenshots or screencast

Screenshot 2024-05-10 at 5 45 46 PM - You can see that, list type is selected by default.

@hbhalodia hbhalodia requested a review from ajitbohra as a code owner May 10, 2024 12:17
Copy link

Warning: Type of PR label mismatch

To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.

  • Type-related labels to choose from: [Type] Automated Testing, [Type] Breaking Change, [Type] Bug, [Type] Build Tooling, [Type] Code Quality, [Type] Copy, [Type] Developer Documentation, [Type] Enhancement, [Type] Experimental, [Type] Feature, [Type] New API, [Type] Task, [Type] Technical Prototype, [Type] Performance, [Type] Project Management, [Type] Regression, [Type] Security, [Type] WP Core Ticket, Backport from WordPress Core.
  • Labels found: .

Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task.

Copy link

github-actions bot commented May 10, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: hbhalodia <hbhalodia@git.wordpress.org>
Co-authored-by: afercia <afercia@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@afercia
Copy link
Contributor

afercia commented May 13, 2024

Thanks for this PR @hbhalodia. Not my area of expertise but I'd investigate why the Post Template block doesn't have the layout attribute default in the block.json in the first place.
Cc @tellthemachines I see relevant changes from #49050 your eyes here would be appreciated 🙏🏽

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Post Template block: 'List view' display setting should be selected by default
2 participants