Fix being unable to switch modes while inserter is open #61563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
jeryj
added
[Type] Bug
|
Size Change: +13 B (0%) Total Size: 1.74 MB
ℹ️ View Unchanged
|
scruffian
approved these changes
May 10, 2024
alexstine
reviewed
May 13, 2024
There was a problem hiding this comment.
@jeryj This is almost testing perfectly. This might be a new bug so feel free to address in another issue/PR.
- Open the inserter.
- Insert a paragraph block.
- Type some text.
- Press Escape to enter navigation mode.
- Press Enter to resume editing.
- Notice how there is now a focus loss, rich text paragraph field does not regain focus.
- Pressing Tab again lands on the paragraph block toolbar.
Tested in Firefox on Windows.
|
@alexstine I did your reproduction steps on Chrome and in Firefox on Mac in both the post editor and site editor and couldn't reproduce. Could you try again on trunk now that this is merged and see if it's still an issue? It's possible it was unrelated and got fixed on trunk. |
|
@jeryj I just built off latest trunk and can still replicate. I can also no longer tab out of the inserter panel. Did this PR get reverted? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug reported by @alexstine
What?
Fixes a bug where when the inserter was open, you could not switch modes. This was due to the useZoomOut hook switching modes.
Why?
Fix being unable to switch modes while inserter is open.
How?
Adds a check to only switch away from 'zoom-out' mode if we are indeed in zoom out mode.
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast