Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Devastation] Rework Shattering Star module #6765

Merged
merged 31 commits into from
May 20, 2024
Merged

[Devastation] Rework Shattering Star module #6765

merged 31 commits into from
May 20, 2024

Conversation

Krealle
Copy link
Contributor

@Krealle Krealle commented May 12, 2024

Description

Reworked Shattering Star module, by request of @ljosberinn, to be more informative.

  • Guide section updated to make use of performance checkboxes
  • Added statistics to show damage breakdown:
    • Shattering Star itself
    • Base amped damage
    • Focusing Iris amped damage
    • Donut chart for amped spells breakdown
  • Properly account for spells with travel time for damage calc

Testing

/report/KQbmv4fYktMACLNa/53-Mythic+Volcoross+-+Kill+(3:28)/Vollmer/standard/overview

image
image
image
image

/report/agQHN2BpZPGn1mT4/47-LFR+Gnarlroot+-+Kill+(2:15)/Reptilian/standard/statistics

image
image

@Krealle
Initial impl of new Shattering Star module
502adca
@Krealle
Add irid perf check and stats
fe1ed94
@Krealle
Merge https://github.com/WoWAnalyzer/WoWAnalyzer into shattering-star
66c7920
@Krealle
We no longer play around Irid blue
581b04f
@Krealle
Add S4 dot to whitelist
b40d82d
@Krealle
Merge https://github.com/WoWAnalyzer/WoWAnalyzer into shattering-star
16ba0b0
@Krealle
add essence burst generation performance check
94b3e1e
@Krealle
add essence burst perf to actualPerformance check
fc82db5
@Krealle
use empowerEnd events for empowers now that they are normalized
bed5019
@Krealle
shards isnt whitelisted
1639764
@Krealle
calculate eternity surge damage on cast instead of on hit
f543de4
@Krealle
update statistics
d743e27
@Krealle
Update check to account for focusing iris
bd29afb
@Krealle
Replace old shattering star module
656a72d
@Krealle
Add note about what damage is amped
e93ed8b
@Krealle
remove test entry
351addc
@Krealle
some general cleanup
190f60d
@Krealle
Merge https://github.com/WoWAnalyzer/WoWAnalyzer into shattering-star
9cff901
@Krealle
Calculate Living Flame damage on cast
c4ca694
@Krealle
make weak casts array into set
11ef26a
@Krealle
some more cleanup
e797175
@Krealle
move amp multiplier to constants
0696010
@Krealle
move Shattering Star guidesection into its own module
c3e19cf
@Krealle
make stats not show up twice
d88c943
@Krealle
Implement Focusing Iris
fc331d0
@Krealle
cleanup addAmpedDamage
c648e73
@Krealle
remove unused prop in ShatteringStarWindow
348f73f
@Krealle
rename var
050046d
@Krealle
fix oopsie
1b2a4ec
@Krealle
Only show "only" on Ok perf
99c9125
@emallson emallson added this pull request to the merge queue May 20, 2024
Merged via the queue into WoWAnalyzer:dragonflight with commit 294bfa2 May 20, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emallson emallson emallson approved these changes

Assignees
No one assigned
Labels
Dragonflight Evoker
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Krealle @emallson