[WIP] Fury Warrior Support #6481
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Using same order as Protection
Supporting Reckless Abandon by normalizing the Reckless versions to the default versions. This makes cooldowns, casts, and everything, easier to manage, but _might_ be confusing for the enduser.
It was written for 9.X version of Reckless Abandon. 10.x Reckless Abandon is a completely different talent, and would need a new module.
Rewrite Anger Management Module to correctly reduce cooldown of Ravager as well as Recklessness. Also rewrite statistic module to show number of extra casts afforded by the reduced CD.
It was written around the Shadowlands version of the talent which let whirlwind procc Enrage.
Remove code for tracking getting hit (since it triggers "Rage" spell), update rage-per-swing, and handle recklessness rage increase.
- Normalize rage values correctly - Add graph to Rage usage tab - Prettyprint total values
- Fix tracking of rage generation - Remove damage tracking > It was a bit awkward that it was tracking "% damage during recklessness", it could be read as "damage done by recklessness" which is not the case
If you have Improved Enrage talent, the Enrage buff will improve your Haste by 15%, so if you have the talent, we add the buff to the Haste module to be tracked.
Both the Warrior talent Wild Strikes and the Fury talent Swift Strikes increases your haste by 1% per stack, so if you have any stacks of either, we permanently increase your haste by 1% per stack.
This was added in 6e5ea08. It is possible that it was needed then, but looking at current logs, it appears it is not needed. Only the clicked spell is "cast", even if other spells are applied.
The timeline gets really messy because most abilities keeps replacing the buff. Also tracking haste changes becomes really messy because it is modified for every single attack. By normalizing them to refresh, we cleanup a lot of events and makes following operations simpler. For example, the normalizer to put the enrage events before the bloodthirsts will be simpler since we only have to reorder the Refresh event.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Testing
/report/...