Fix of issue of modification on active tunnel #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: George Kutsurua <g.kutsurua@gmail.com>
suquant
force-pushed
the
f/fix-tunnel-status-proccessing
branch
from
256f43b
to
d08ee36
Compare
|
Hello, when the IP address of the server changes, the client will lose the VPN connection and must restart the client to recover. Can you help solve this problem? thank you |
kar
added a commit
to blokadaorg/wireguard-apple
that referenced
this pull request
Dec 16, 2022
May be relevant. WireGuard/wireguard-apple#7
zx2c4-bot
force-pushed
the
master
branch
2 times, most recently
from
c37881b
to
2fec12a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: George Kutsurua g.kutsurua@gmail.com
Hello,
This pr contains a fix for the case when the tunnels manager modifies the active tunnel.
Use case:
Once the active tunnel is modified it is sometimes disconnected and does not connect back again, sometimes it is stuck in "waiting" status.
Description of the issue:
When we are modifying the active tunnel there process tunnel's status programmatically changes its status to "restarting" and later this status processes properly (connect back disconnected tunnel). But problem is that once the tunnel changes its configuration "reload()" is triggered in "startObservingTunnelConfigurations" function and it is replacing tunnels, so programmatically set status never reaches. It works sometimes well because of "reload" function executes after status processing and sometimes not, depends when reload start's its execution.