UI: improve handling of incomplete locales #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Iksas
force-pushed
the
localization-fix
branch
from
19a9898
to
8feb3ff
Compare
…lation Signed-off-by: Iksas <iksas@mailbox.org>
Signed-off-by: Iksas <iksas@mailbox.org>
Iksas
force-pushed
the
localization-fix
branch
from
8feb3ff
to
ae84523
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the current macOS and iOS apps, keys are visible in the UI if a translation is missing:
This PR implements support for incomplete locales. Translations no longer need to be synced. Instead, if a translation is missing, the English string from the
Base.lprojbundle is used.All English strings that were added to incomplete locales (mainly in 49b7d08) are removed, because they are no longer needed.