Use alternate method for quick-tile #64
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The abrupt disappearance of the quicktile-menu could be improved by providing an alternative layout to the TunnelToggleActivity which is only show when it was called by the quicktile. Generally this is only an issue when the app was in background and no tunnel is available, otherwise the quicktile works as intended. |
Signed-off-by: Felix Nüsse <felix.nuesse@t-online.de>
Signed-off-by: Felix Nüsse <felix.nuesse@t-online.de>
Signed-off-by: Felix Nüsse <felix.nuesse@t-online.de>
|
I have added a dummy-progressbar which will be shown in case the app was in background. It stays for 1000ms and then closes itself, after the tunnel has been triggered. This makes the transition way more visually pleasing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change removes the need for the permission to draw over other apps.
Personally, i find this permission a bit intrusive, so i tried to find a different mechanism to start up a tunnel.
The new one uses a trick to start an activity completely invisible, and immediately move it to the backstack.
The only drawback that i found is that the quicktile-menu immediately disappears on clicking the tile, instead of slowly closing.